[U-Boot] [PATCH 1/2 v3] env: only build env_embedded and envcrc when needed

Wolfgang Denk wd at denx.de
Tue Sep 15 22:45:13 CEST 2009


Dear Mike Frysinger,

In message <1252511443-1638-1-git-send-email-vapier at gentoo.org> you wrote:
> The env code is protected by the ENV_IS_EMBEDDED define, so attempting to
> compile the code when this isn't defined is pointless.  Now that the env
> headers have unified around CONFIG_ENV_IS_EMBEDDED, convert the build
> system to only build the env objects when this is enabled.  And now that
> the env code is conditionally compiled, we can drop the source code checks.
> 
> For people who want to extract the environment manually, add a new option
> that only enables the envcrc utility (CONFIG_ENV_IS_EMBEDDED_CUSTOM).

I see no users, and I hesitate to add dead code.

And CONFIG_ENV_IS_EMBEDDED_CUSTOM is an ugly and misleading name.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All a hacker needs is a tight PUSHJ, a loose pair of UUOs, and a warm
place to shift.


More information about the U-Boot mailing list