[U-Boot] [PATCH 2/7] mpc85xx: Add eSDHC support for MPC8569E-MDS boards

Kumar Gala galak at kernel.crashing.org
Wed Sep 16 06:15:51 CEST 2009


On Aug 19, 2009, at 1:37 PM, Anton Vorontsov wrote:

> eSDHC is mutually exlusive with UART0* and I2C2. When eSDHC is
> used, we should switch u-boot console to UART1, and make the
> proper device-tree fixups.
>
> * Actually, according to User's Guide we can use eSDHC in serial
>  (1-bit) mode without disabling UART0, but for me it doesn't work
>  on prototype boards.
>
> Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>
> ---
> board/freescale/mpc8569mds/mpc8569mds.c |   85 ++++++++++++++++++++++ 
> +++++++++
> cpu/mpc85xx/speed.c                     |    2 +
> include/asm-ppc/global_data.h           |    3 +-
> include/configs/MPC8569MDS.h            |   16 ++++++
> 4 files changed, 105 insertions(+), 1 deletions(-)
>
> diff --git a/board/freescale/mpc8569mds/mpc8569mds.c b/board/ 
> freescale/mpc8569mds/mpc8569mds.c
> index 1e7526a..7c1aaa5 100644
> --- a/board/freescale/mpc8569mds/mpc8569mds.c
> +++ b/board/freescale/mpc8569mds/mpc8569mds.c
> @@ -23,6 +23,7 @@
>  */
>
> #include <common.h>
> +#include <hwconfig.h>
> #include <pci.h>
> #include <asm/processor.h>
> #include <asm/mmu.h>
> @@ -35,6 +36,7 @@
> #include <ioports.h>
> #include <libfdt.h>
> #include <fdt_support.h>
> +#include <fsl_esdhc.h>
>
> #include "bcsr.h"
>
> @@ -303,6 +305,87 @@ local_bus_init(void)
> 	out_be32(&lbc->lcrr, (u32)in_be32(&lbc->lcrr)| 0x00030000);
> }
>
> +#ifdef CONFIG_FSL_ESDHC
> +int board_mmc_init(bd_t *bd)
> +{
> +	struct ccsr_gur *gur = (struct ccsr_gur *) 
> CONFIG_SYS_MPC85xx_GUTS_ADDR;
> +	u8 *bcsr = (u8 *)CONFIG_SYS_BCSR_BASE;
> +
> +	if (!hwconfig("esdhc"))
> +		return 0;
> +
> +	printf("Enabling eSDHC...\n"
> +	       "  For eSDHC to function, UART0 and I2C2 should be disabled. 
> \n"
> +	       "  Redirecting stderr, stdout and stdin to UART1...\n");
> +	console_assign(stderr, "eserial1");
> +	console_assign(stdout, "eserial1");
> +	console_assign(stdin, "eserial1");
> +	printf("Switched to UART1 (initial log has been printed to UART0). 
> \n");
> +
> +	/* Assign I2C2 signals to eSDHC. */
> +	clrsetbits_be32(&gur->plppar1, PLPPAR1_I2C_BIT_MASK,
> +				       PLPPAR1_ESDHC_VAL);
> +	clrsetbits_be32(&gur->plpdir1, PLPDIR1_I2C_BIT_MASK,
> +				       PLPDIR1_ESDHC_VAL);
> +
> +	/* Mux UART0 & I2C2 signals to eSDHC. */
> +	setbits_8(&bcsr[6], BCSR6_SD_ENABLE);
> +
> +	return fsl_esdhc_mmc_init(bd);
> +}
> +
> +static void fdt_board_fixup_esdhc(void *blob, bd_t *bd)
> +{
> +	const char *status = "disabled";
> +	int off;
> +	int err;
> +
> +	/*
> +	 * In case of enabled eSDHC, we should disable UART0 and I2C2
> +	 * in the device tree, otherwise nothing to do.
> +	 */
> +	if (!hwconfig("esdhc"))
> +		return;
> +
> +	off = fdt_path_offset(blob, "serial0");
> +	if (off < 0) {
> +		printf("WARNING: could not find serial0 alias: %s.\n",
> +			fdt_strerror(off));
> +		goto disable_i2c2;
> +	}
> +
> +	err = fdt_setprop(blob, off, "status", status, strlen(status) + 1);
> +	if (err) {
> +		printf("WARNING: could not set status for serial0: %s.\n",
> +			fdt_strerror(err));
> +		return;
> +	}
> +
> +disable_i2c2:
> +	off = -1;
> +	while (1) {
> +		const u32 *idx;
> +		int len;
> +
> +		off = fdt_node_offset_by_compatible(blob, off, "fsl-i2c");
> +		if (off < 0)
> +			break;
> +
> +		idx = fdt_getprop(blob, off, "cell-index", &len);
> +		if (!idx || len != sizeof(*idx))
> +			continue;
> +
> +		if (*idx == 1) {
> +			fdt_setprop(blob, off, "status", status,
> +				    strlen(status) + 1);
> +			break;
> +		}
> +	}
> +}
> +#else
> +static inline void fdt_board_fixup_esdhc(void *blob, bd_t *bd) {}
> +#endif
> +
> #ifdef CONFIG_PCIE1
> static struct pci_controller pcie1_hose;
> #endif  /* CONFIG_PCIE1 */
> @@ -449,5 +532,7 @@ void ft_board_setup(void *blob, bd_t *bd)
> #ifdef CONFIG_PCIE1
> 	ft_fsl_pci_setup(blob, "pci1", &pcie1_hose);
> #endif
> +	fdt_fixup_esdhc(blob, bd);

ft_cpu_setup() calls fdt_fixup_esdhc() for us now.

> +	fdt_board_fixup_esdhc(blob, bd);
> }
> #endif
> diff --git a/cpu/mpc85xx/speed.c b/cpu/mpc85xx/speed.c
> index 286b6b2..73ecb76 100644
> --- a/cpu/mpc85xx/speed.c
> +++ b/cpu/mpc85xx/speed.c
> @@ -155,6 +155,8 @@ int get_clocks (void)
>
> #if defined(CONFIG_MPC8536)
> 	gd->sdhc_clk = gd->bus_clk / 2;
> +#elif defined(CONFIG_MPC8569)
> +	gd->sdhc_clk = gd->bus_clk;
> #endif

This shouldn't be needed, replaced with CONFIG_FSL_ESDHC

>
> #if defined(CONFIG_CPM2)
> diff --git a/include/asm-ppc/global_data.h b/include/asm-ppc/ 
> global_data.h
> index 244c161..7cbcdb7 100644
> --- a/include/asm-ppc/global_data.h
> +++ b/include/asm-ppc/global_data.h
> @@ -86,7 +86,8 @@ typedef	struct	global_data {
> 	u32  mem_sec_clk;
> #endif /* CONFIG_MPC8360 */
> #endif
> -#if defined(CONFIG_MPC837x) || defined(CONFIG_MPC8536)
> +#if defined(CONFIG_MPC837X) || defined(CONFIG_MPC8536) || \
> +		defined(CONFIG_MPC8569)
> 	u32 sdhc_clk;
> #endif

This shouldn't be needed, replaced with CONFIG_FSL_ESDHC

> #if defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx)
> diff --git a/include/configs/MPC8569MDS.h b/include/configs/ 
> MPC8569MDS.h
> index 32e747e..3d07a5b 100644
> --- a/include/configs/MPC8569MDS.h
> +++ b/include/configs/MPC8569MDS.h
> @@ -70,6 +70,7 @@ extern unsigned long get_clock_freq(void);
> #define CONFIG_ENABLE_36BIT_PHYS	1
>
> #define CONFIG_BOARD_EARLY_INIT_F	1	/* Call board_pre_init */
> +#define CONFIG_HWCONFIG
>
> #define CONFIG_SYS_MEMTEST_START	0x00200000	/* memtest works on */
> #define CONFIG_SYS_MEMTEST_END		0x00400000
> @@ -206,6 +207,7 @@ extern unsigned long get_clock_freq(void);
>
> /* Serial Port */
> #define CONFIG_CONS_INDEX		1
> +#define CONFIG_SERIAL_MULTI		1
> #undef	CONFIG_SERIAL_SOFTWARE_FIFO
> #define CONFIG_SYS_NS16550
> #define CONFIG_SYS_NS16550_SERIAL
> @@ -258,8 +260,10 @@ extern unsigned long get_clock_freq(void);
>
> #define PLPPAR1_I2C_BIT_MASK		0x0000000F
> #define PLPPAR1_I2C2_VAL		0x00000000
> +#define PLPPAR1_ESDHC_VAL		0x0000000A
> #define PLPDIR1_I2C_BIT_MASK		0x0000000F
> #define PLPDIR1_I2C2_VAL		0x0000000F
> +#define PLPDIR1_ESDHC_VAL		0x00000006
>
> /*
>  * General PCI
> @@ -450,6 +454,18 @@ extern unsigned long get_clock_freq(void);
>
> #undef CONFIG_WATCHDOG			/* watchdog disabled */
>
> +#define CONFIG_MMC     1

Why don't we set CONFIG_FSL_ESDHC?


> +
> +#ifdef CONFIG_MMC
> +#define CONFIG_FSL_ESDHC
> +#define CONFIG_SYS_FSL_ESDHC_ADDR	CONFIG_SYS_MPC85xx_ESDHC_ADDR
> +#define CONFIG_CMD_MMC
> +#define CONFIG_GENERIC_MMC
> +#define CONFIG_CMD_EXT2
> +#define CONFIG_CMD_FAT
> +#define CONFIG_DOS_PARTITION
> +#endif
> +
> /*
>  * Miscellaneous configurable options
>  */
> -- 
> 1.6.3.3



More information about the U-Boot mailing list