[U-Boot] [PATCH] ppc/85xx: Fix LCRR_CLKDIV defines

Peter Tyser ptyser at xes-inc.com
Wed Sep 16 06:38:51 CEST 2009


On Tue, 2009-09-15 at 23:11 -0500, Kumar Gala wrote:
> On Sep 15, 2009, at 10:32 PM, Peter Tyser wrote:
> 
> > On Tue, 2009-09-15 at 22:26 -0500, Kumar Gala wrote:
> >> For some reason the CLKDIV field varies between SoC in how it  
> >> interprets
> >> the bit values.
> >>
> >> All 83xx and early (e500v1) PQ3 devices support:
> >> clk/2: CLKDIV = 2
> >> clk/4: CLKDIV = 4
> >> clk/8: CLKDIV = 8
> >>
> >> Newer PQ3 (e500v2) and MPC86xx support:
> >> clk/4: CLKDIV = 2
> >> clk/8: CLKDIV = 4
> >> clk/16: CLKDIV = 8
> >>
> >> Ensure that the MPC86xx and MPC85xx still get the same behavior and  
> >> make
> >> the the defines reflect their logical view (not the value of the  
> >> field).
> >>
> >> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> >
> > Acked-by: Peter Tyser <ptyser at xes-inc.com>
> 
> Peter,
> 
> I did notice that we dont actually set LCRR anywhere :)

Lol, that's great:)  CONFIG_SYS_LBC_LCRR does affect the value of
sysinfo.freqLocalBus and thus gd->lbc_clk.  And sysinfo.freqLocalBus is
used to print the LBC frequency on bootup which added to the delusion
that I was speeding it up:)

A few other boards seem to define CONFIG_SYS_LBC_LCRR, but don't
implement a board-specific modification of the LBCC register, so they
should have the same "bug".

I'll take a closer look tomorrow.

Peter



More information about the U-Boot mailing list