[U-Boot] [PATCH 3/3] fsl_i2c: Impl. AN2819, rev 5 to calculate FDR/DFSR

[Wolfgang Denk]

Dear Joakim Tjernlund,

In message <OF0E2B8150.47DDCD99-ONC1257634.0023E2E7-C1257634.002481BA at transmode.se> you wrote:
> 
> > > +   u8 dfsr, fdr = 0x31; /* Default if no FDR found */
> > > +   unsigned short A, B, Ga, Gb;
> >
> > Please do not use mixed-case variables, thanks.
> 
> A and B are from the AN2819 spec and I used the same names to ease
> identify with the spec. I rather keep them.

Feel free to add a comment to explain the relation, but please use
only lower-case identifiers.

...
> Like so?
> for(Ga = 0x4, A = 10; A <= 30; Ga++, A += 2) {

Please also here:

	for (...)


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It's certainly  convenient  the  way  the  crime  (or  condition)  of
stupidity   carries   with   it  its  own  punishment,  automatically
admisistered without remorse, pity, or prejudice. :-)
         -- Tom Christiansen in <559seq$ag1$1 at csnews.cs.colorado.edu>