[U-Boot] [PATCH 1/8] sbc8548: delete unused MPC8548CDS info carried over from port

Kumar Gala galak at kernel.crashing.org
Sat Sep 19 18:34:30 CEST 2009


On Sep 19, 2009, at 11:05 AM, Paul Gortmaker wrote:

> Kumar Gala wrote:
>> On Sep 18, 2009, at 6:08 PM, Paul Gortmaker wrote:
>>> There are a couple defines and PCI bridge quirks related to the PCI
>>> backplane of the MPC8548CDS that have no meaning in the context of
>>> the port to the sbc8548 board, so delete them.
>>>
>>> Also, the form factor of the sbc8548 is a standalone board with a
>>> single PCI-X and a single PCI-e slot.  That pretty much guarantees
>>> that it will never be a PCI agent itself, so the host/agent and root
>>> complex/end node distinctions have been removed.
>>>
>>> Similarly, since there is no physical connector mapping to PCI2, so
>>> all references of PCI2 in the board support files have been removed
>>> as well.
>>>
>>> Signed-off-by: Paul Gortmaker <paul.gortmaker at windriver.com>
>>> ---
>>> board/sbc8548/sbc8548.c   |   63 +++ 
>>> +----------------------------------------
>>> include/configs/sbc8548.h |    9 ------
>>> 2 files changed, 6 insertions(+), 66 deletions(-)
>> Can we look at using fsl_pci_init_port()?
>
> Sure.
>
>> See my recent patches for p2020/mpc8572ds/mpc8536ds
>
> What did you have in mind - me creating a similar patch
> like the above to layer on what I've got now, or is there
> a preference for me to munge the same change into the
> existing  5/8 PCI update patch?  I guess the former gives
> an extra bisection point...

Which ever works for you, the later sounds a bit easier to review.

- k


More information about the U-Boot mailing list