[U-Boot] [PATCH v3] MAKEALL: Add summary information

Peter Tyser ptyser at xes-inc.com
Mon Sep 21 01:24:32 CEST 2009


On Mon, 2009-09-21 at 00:09 +0200, Wolfgang Denk wrote:
> Dear Peter Tyser,
> 
> In message <1253317683-2831-1-git-send-email-ptyser at xes-inc.com> you wrote:
> >
> >  if [ "$BUILD_NCPUS" -gt 1 ]
> >  then
> > -	JOBS=-j`expr "$BUILD_NCPUS" + 1`
> > +	JOBS="-j $(($BUILD_NCPUS + 1))"
> >  else
> >  	JOBS=""
> >  fi
> 
> This is an unrelated change. I would not include it with this patch.

Mike mentioned using POSIX math in the new arithmetic functions I added,
which makes sense.  I reasoned it was better to convert the 1 other
reference to 'expr + 1' to the same POSIX style for consistency's sake.
Changing 1 'expr + 1' reference to $((+ 1)) doesn't seem worth its own
commit, so I rolled it into this patch.  How about I just add a sentence
to the commit message stating that I also converted math operations to
be POSIX compliant?

Best,
Peter



More information about the U-Boot mailing list