[U-Boot] [PATCH v2] MAKEALL: Add summary information

Peter Tyser ptyser at xes-inc.com
Mon Sep 21 01:39:56 CEST 2009


> > +# Print statistics when ctrl-c is pressed
> > +trap "print_stats; exit " 2
> 
> Why only on signal 2? Usually we use "1 2 3 15" in such cases.

2's the only case I've ever used for MAKEALL, I'll add the other cases
as you suggest.

> Also, you might add "0" here and then...
> 
> > @@ -932,3 +956,5 @@ do
> >  			;;
> >  	esac
> >  done
> > +
> > +print_stats

I didn't trap 0 because I wasn't aware of a quick way to only call
print_stats once when ctrl-c was pressed (eg trapping 0 and 2 would
result in 2 print_stats calls with the current code).  Let me know if
there's a standard way to workaround this.

Best,
Peter



More information about the U-Boot mailing list