[U-Boot] [PATCH 4/4 v3] s5pc1xx: add support SMDKC100 board

[Tom]

Minkyu Kang wrote:
> Adds new board SMDKC100 that uses s5pc100 SoC
> 
> Signed-off-by: Minkyu Kang <mk7.kang at samsung.com>
> Signed-off-by: HeungJun, Kim <riverful.kim at samsung.com>
> ---
> Changes since v1:
> - arrange env values for more readable
> - make C struct instead of base+offset
> - use MACH_TYPE_SMDKC100 directly
> - fix the CONFIG_SYS_HZ to 1000
> - enable LOADB, LOADS, BOOTD, XIMG, FPGA
> 
> Changes since v2:
> - remove <asm/sizes.h> and SZ_XX defines
> - remove the define of machine type
> - remove the unnecessary comment
> 
>  MAINTAINERS                            |    4 +
>  MAKEALL                                |    1 +
>  Makefile                               |    3 +
>  board/samsung/smdkc100/Makefile        |   55 +++++++
>  board/samsung/smdkc100/config.mk       |   16 ++
>  board/samsung/smdkc100/lowlevel_init.S |  215 ++++++++++++++++++++++++++++
>  board/samsung/smdkc100/mem_setup.S     |  197 ++++++++++++++++++++++++++
>  board/samsung/smdkc100/onenand.c       |   83 +++++++++++
>  board/samsung/smdkc100/smdkc100.c      |   51 +++++++
>  include/configs/smdkc100.h             |  242 ++++++++++++++++++++++++++++++++
>  10 files changed, 867 insertions(+), 0 deletions(-)
>  create mode 100644 board/samsung/smdkc100/Makefile
>  create mode 100644 board/samsung/smdkc100/config.mk
>  create mode 100644 board/samsung/smdkc100/lowlevel_init.S
>  create mode 100644 board/samsung/smdkc100/mem_setup.S
>  create mode 100644 board/samsung/smdkc100/onenand.c
>  create mode 100644 board/samsung/smdkc100/smdkc100.c
>  create mode 100644 include/configs/smdkc100.h
> 

Please include a brief readme doc/README.s5pc1xx similar to README.omap

<snip>

> +
> +#ifndef CONFIG_ONENAND_IPL
> +	/* setting SRAM */
> +	ldr	r0, =S5PC100_SROMC_BASE
> +	ldr	r1, =0x9
> +	str	r1, [r0]
> +#endif

Where is CONFIG_ONENAND_IPL defined ?
If it is not being used, the #ifndef logic should be reduced.

Tom