[U-Boot] [PATCH] TI: DaVinci DM365: Enabling net support on DM365

[Wolfgang Denk]

Dear s-paulraj at ti.com,

In message <1252955798-31840-1-git-send-email-s-paulraj at ti.com> you wrote:
> From: Sandeep Paulraj <s-paulraj at ti.com>
> 
> This patch enables EMAC on the DM365 EVM.
> 
> Signed-off-by: Sandeep Paulraj <s-paulraj at ti.com>
> ---
>  board/davinci/dm365evm/dm365evm.c |   38 +++++++++++++++++++++++++++++++++++++
>  1 files changed, 38 insertions(+), 0 deletions(-)
...
> +	/* Configure PINMUX 3 to enable EMAC pins */
> +	writel((readl(PINMUX3) | 0x1affff), PINMUX3);
> +
> +	/* Configure GPIO20 as output */
> +	writel((readl(GIO_DIR01) & 0xffefffff), GIO_DIR01);

Please use C structs to dsescribe the register layout. Do not use
typeless addresses.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To know how another being, another creature feels -  that  is  impos-
sible.                  - Terry Pratchett, _The Dark Side of the Sun_