[U-Boot] [PATCH v3 1/3] NAND boot: MPC8536DS support

[Wolfgang Denk]

Dear Mingkai Hu,

In message <1253244935-1555-1-git-send-email-Mingkai.hu at freescale.com> you wrote:
> MPC8536E can support booting from NAND flash which uses the
> image u-boot-nand.bin. This image contains two parts: a 4K
> NAND loader and a main U-Boot image. The former is appended
> to the latter to produce u-boot-nand.bin. The 4K NAND loader
> includes the corresponding nand_spl directory, along with the
> code twisted by CONFIG_NAND_SPL. The main U-Boot image just
> like a general U-Boot image except the parts that included by
> CONFIG_SYS_RAMBOOT.
> 
> When power on, eLBC will automatically load from bank 0 the
> 4K NAND loader into the FCM buffer RAM where CPU can execute
> the boot code directly. In the first stage, the NAND loader
> copies itself to RAM or L2SRAM to free up the FCM buffer RAM,
> then loads the main image from NAND flash to RAM or L2SRAM
> and boot from it.
> 
> This patch implements the NAND loader to load the main image
> into L2SRAM, so the main image can configure the RAM by using
> SPD EEPROM. In the first stage, the NAND loader copies itself
> to the second to last 4K address space, and uses the last 4K
> address space as the initial RAM for stack.
> 
> Obviously, the size of L2SRAM shouldn't be less than the size
> of the image used. If so, the workaround is to generate another
> image that includes the code to configure the RAM by SPD and
> load it to L2SRAM first, then relocate the main image to RAM
> to boot up.
> 
> Signed-off-by: Mingkai Hu <Mingkai.hu at freescale.com>
> ---
> 
> Change over v2:
>  - Intergrated Kumar's comments.
>  - Aligned to the leatest git tree

I am a bit surprised about your way to number patch versions ;-)

We had a "[PATCH v3 1/3] NAND boot: MPC8536DS support" on Sep 18
already, and now again.

But OK, the things I complained about for the old version are still
present, too.

Please fix - but then update the version, too, please.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Without freedom of choice there is no creativity.
	-- Kirk, "The return of the Archons", stardate 3157.4