[U-Boot] [PATCH 1/1] SPARC: fixes exported function stub for standalone applications.

[Daniel Hellstrom]

Wolfgang Denk wrote:

>Dear Daniel Hellstrom,
>
>In message <1253270387-15741-1-git-send-email-daniel at gaisler.com> you wrote:
>  
>
>>Hello Wolfgang,
>>
>>Please pull the u-boot-sparc.git master branch.
>>
>>This patch fixes the SPARC support for standalone u-boot applications. 
>>The problem was that I neve finished the implementation in the first
>>place.
>>
>>jmp ensures we get back to the location we came from, size(void *) make
>>sure we get the function addresses correctly from the table (entry*4 
>>instead of entry*1).
>>    
>>
>
>Um...
>...
>  
>
>>Signed-off-by: Daniel Hellstrom <daniel at gaisler.com>
>>---
>> examples/standalone/stubs.c |    4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>>diff --git a/examples/standalone/stubs.c b/examples/standalone/stubs.c
>>index 339bbf9..ce3371d 100644
>>--- a/examples/standalone/stubs.c
>>+++ b/examples/standalone/stubs.c
>>@@ -181,9 +181,9 @@ gd_t *global_data;
>> "	or %%g1, %%g7, %%g1\n"				\
>> "	ld [%%g1], %%g1\n"				\
>> "	ld [%%g1 + %1], %%g1\n"				\
>>-"	call %%g1\n"					\
>>+"	jmp %%g1\n"					\
>> "	nop\n"						\
>>-	: : "i"(offsetof(gd_t, jt)), "i"(XF_ ## x) : "g1" );
>>+	: : "i"(offsetof(gd_t, jt)), "i"(XF_ ## x * sizeof(void *)) : "g1" );
>>    
>>
>
>This looks 100% like the patch submitted by Sergey Mironov on 16 Sep,
>yet I see no Signed-off-by: line from him, nor any credit or
>reference.
>
>This can't be right?
>  
>
Hello Wolfgang,

It is 100% his patch, I have only reviewed and tried it.

I admit it looks disgusting.

I will ask Sergey for a new patch with a signoff line, I will let you 
know when the repository is updated. I suppose I will use the "git am 
--signoff --whitespace=strip" you have written about on the git help page.

How do you deal with cyrillic in the sign-off line?

Best Regards,
Daniel Hellstrom