[U-Boot] [PATCH] relocation: Do not relocate NULL pointers.

Stefan Roese sr at denx.de
Wed Sep 23 14:24:34 CEST 2009


On Wednesday 23 September 2009 13:51:46 Joakim Tjernlund wrote:
> NULL is an absolute value and should not be relocated.
> After this correction code like:
>  void weak_fun(void) __attribute__((weak));
>  printf("weak_fun:%p\n", weak_fun);
> will still print null after relocation.
> 
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
> ---
> 
> I have only tested this on 83xx and on a somewhat older u-boot.
> The change is exactly the same on all PowerPC platforms though.
> 
>  cpu/mpc512x/start.S |    6 ++++--
>  cpu/mpc5xx/start.S  |    6 ++++--
>  cpu/mpc5xxx/start.S |    6 ++++--
>  cpu/mpc8220/start.S |    6 ++++--
>  cpu/mpc824x/start.S |    6 ++++--
>  cpu/mpc8260/start.S |    6 ++++--
>  cpu/mpc83xx/start.S |    6 ++++--
>  cpu/mpc85xx/start.S |    6 ++++--
>  cpu/mpc86xx/start.S |    6 ++++--
>  cpu/mpc8xx/start.S  |    6 ++++--

Thanks. But I think you missed ppc4xx here:

cpu/ppc4xx/start.S

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de


More information about the U-Boot mailing list