[U-Boot] [PATCH] vxworks: Add CONFIG_VXWORKS_PREBOOT

[Tom]

Niklaus Giger wrote:
> Am Mittwoch 23 September 2009 13:39:55 schrieb Tom:
>> Niklaus Giger wrote:
>>> The option CONFIG_VXWORKS_PREBOOT allows a board specific
>>> vxworks_preboot to be run just before jumping into the
>>> vxWorks images. This can be used to alter a register
>>> which is used differently by U-boot and vxWorks.
> <..>
>>>  	puts ("## vxWorks terminated\n");
>>> diff --git a/include/vxworks.h b/include/vxworks.h
>>> index 1633904..df2b580 100644
>>> --- a/include/vxworks.h
>>> +++ b/include/vxworks.h
>>> @@ -50,4 +50,8 @@ int do_bootvx(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]);
>>>  #define CONFIG_SYS_VXWORKS_SERVERNAME	"srv"
>>>  #endif
>>>  
>>> +#ifdef CONFIG_VXWORKS_PREBOOT
>>> +    void vxworks_preboot(void);
>>> +#endif
>>> +
>> Where is vxworks_preboot defined ?
> This patch should only give the basis for its use.
> 
> I use it in one of my Netstal boards MCU25. Patch will come soon, as I am cleaning 
> them up at the moment. But the relevant snippet is here:
> 
> board/netstal/mcu25/mcu25.c
> 
> void vxworks_preboot(void) {
>     if (sys_install_requested())
>         mtdcr(CPC0_CR1, CPCO_CR1_USE_EXTERNAL);
> }
> 
> Is this okay for you? Or do you have more questions? 
> 

This is a good change.

IMO, it would be better if this patch was included with your upcoming
changes as the context of its use would be clear and it would
eliminate that the possibility that this change happened without
follow-up changes.

Tom


> Best regards
> 
> Niklaus
>> Tom
>>
>>>  #endif
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>