[U-Boot] [PATCH] ppc4xx: HCU5 board: add register dump

Stefan Roese sr at denx.de
Wed Sep 23 18:49:34 CEST 2009


Hi Niklaus,

On Wednesday 23 September 2009 17:22:47 Niklaus Giger wrote:
> Adds a HCU5 board specific cmd reghcu5 to dump about 140 internal
> register which define the HW configuration. Needed for documentation
> purposes and to compare different settings.

Apart from Peter's comments, I also have a more general comment. Please 
correct me if I'm wring, but this register dump doesn't seem to be HCU5 
specific, but PPC440EPx specific. If this is the case, we (you) should 
probably move this code into the cpu/ppc4xx directory. Perhaps something like:

cpu/ppc4xx/440epx_regdump.c

What do you think?

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de


More information about the U-Boot mailing list