[U-Boot] [PATCH 4/4 v3] s5pc1xx: add support SMDKC100 board
Kyungmin Park
kmpark at infradead.org
Thu Sep 24 01:43:43 CEST 2009
On Wed, Sep 23, 2009 at 9:05 PM, Tom <Tom.Rix at windriver.com> wrote:
> Minkyu Kang wrote:
>> Dear Tom
>>
>> 2009/9/23 Tom <Tom.Rix at windriver.com>:
>>> Minkyu Kang wrote:
>>>> Adds new board SMDKC100 that uses s5pc100 SoC
>>>>
>>>> Signed-off-by: Minkyu Kang <mk7.kang at samsung.com>
>>>> Signed-off-by: HeungJun, Kim <riverful.kim at samsung.com>
>>>> ---
>
> <snip>
>
>>>> +#ifndef CONFIG_ONENAND_IPL
>>>> + /* setting SRAM */
>>>> + ldr r0, =S5PC100_SROMC_BASE
>>>> + ldr r1, =0x9
>>>> + str r1, [r0]
>>>> +#endif
>>> Where is CONFIG_ONENAND_IPL defined ?
>>> If it is not being used, the #ifndef logic should be reduced.
>>
>> Kyungmin Park sent the patch that is supported onenand_ipl for s5pc1xx.
>> but not yet applied onenand_ipl patch for s5pc1xx.
>> When that patch is applied, we need these logic.
>> If necessary, I'll delete these logic until apply the patch.
>>
>
> If the patch already exits, it would be better if it was in this
> patchset. Can we get the onenand_ipl patch ?
To support the s5pc1xx OneNAND IPL. It needs to refactor the current
OneNAND IPL.
Now I refactor the OneNAND IPL code first and then I will send a
OneNAND IPL codes for s5pc1xx.
I want to leave current patch as is. Since If we delete the OneNAND
IPL codes. No one can refer the codes. I mean OneNAND IPL parts
contains clock and memory configuration. These are helpful to someone
who use NAND or NOR.
Thank you,
Kyungmin Park
More information about the U-Boot
mailing list