[U-Boot] [PATCH] ppc4xx: HCU5 board: add register dump

[Peter Tyser]

On Thu, 2009-09-24 at 11:21 +0200, Stefan Roese wrote:
> On Wednesday 23 September 2009 19:51:24 Niklaus Giger wrote:
> > > > Adds a HCU5 board specific cmd reghcu5 to dump about 140 internal
> > > > register which define the HW configuration. Needed for documentation
> > > > purposes and to compare different settings.
> > >
> > > Apart from Peter's comments, I also have a more general comment. Please
> > > correct me if I'm wring, but this register dump doesn't seem to be HCU5
> > > specific, but PPC440EPx specific. If this is the case, we (you) should
> > > probably move this code into the cpu/ppc4xx directory. Perhaps something
> > >  like:
> > >
> > > cpu/ppc4xx/440epx_regdump.c
> > >
> > > What do you think?
> > 
> > I feel honoured if you consider this patch useful for other boards, too. I
> > will rename the cmd to "440epx_regdump" unless you have a better idea.
> 
> Thinking a bit more about it, we should probably choose a more generic name, 
> so that other 4xx variants may use this command as well. How about just using 
> "regdump"?
> 
> And please base you patch against the "4xx-register-cleanup" branch of my u-
> boot-ppc4xx repo.

What about adding a common 4xx_reginfo() function instead, then calling
it from common/cmd_reginfo.c?  Some of the 4xx dumping already in
cmd_reginfo.c could also be moved to cpu/ppc4xx/[reginfo.c|cpu.c] to
clean it up.  Unless there's a good reason to have both "regdump" and
"reginfo" commands...

Best,
Peter