[U-Boot] [PATCH 1/3 v3] Bit-banged MII driver with multi-bus support.

[Jerry Van Baren]

Hi Luigi,

Luigi 'Comio' Mantellini wrote:
> (autoreview)
> 
> Hi Ben,
> 
> I make some changes to the patch, but I will post after your review.
> See my annotation, that will be present into the next patch release.
> 
> best regards.
> 
> Il mercoledì 23 settembre 2009 15:10:54 Luigi 'Comio' Mantellini ha scritto:
>> From: Luigi 'Comio' Mantellini <luigi.mantellini at idf-hit.com>
>>
>> Signed-off-by: Luigi 'Comio' Mantellini <luigi.mantellini at idf-hit.com>
>> ---
>>  drivers/net/phy/miiphybb.c |  324

[snip]

>> +static inline struct bbmiibus *bb_miiphy_getbus(char *devname)
>> +{
>> +#ifdef CONFIG_BITBANGMII_MULTI
>> +	/* Search the correct bus */
>> +	for (j = 0; j < sizeof(bbmiibusses)/sizeof(bbmmis[0]); j++) {
> 
> [COMIO] Changed j to i and add i declaration.

You may have inherited the "j" loop counter from me.  I stopped using 
"i" in loop counters and started with "j" because most code (variables 
and keywords) do not use words with the letter "j" or "k" in them.  On 
the other hand, A LOT of variables and keywords have "i" in their names. 
  The result is that it is a PAIN to find loop variable references for 
the loop variable "i" but it is usually trivial to find them for "j" and 
"k".

Case in point: how many "i"s does your loop have?  Just in the for() 
loop control line, I count five.

Trivia:
* I find I almost never need to nest loops more than 2 deep, so "j" and 
"k" cover almost all loop variable needs.

* I believe Fortran coding conventions started the "ijk" counter mania.

[snip]

> Any comment is welcome
> 
> best regards,
> 
> luigi

Best regards,
gvb