[U-Boot] [PATCH] part_dos: check status flags of partitions

Daniel Mack daniel at caiaq.de
Mon Sep 28 12:04:00 CEST 2009


The current fatload code has a problem together with the way the DOS
partition parser is implemented.

This hit me when I tried to load a file from a USB stick which had no
partition table but a FAT16 directly written to the first sector.

With such an environment, get_partition_info_extended() still finds a
valid partition at the first sector since the 0x55aa magic is valid for
both the MBR and the FAT boot sector.

As a result, part_offset in fs/fat/fat.c is then set to some ridiculous
value and the code searching for the directory entry gets lots in an
endless loop.

The fix is quite simple though - we just need to check the status field
of the partitions more stricly. According to the specs, it may only
contain 0x00 and 0x80. If get_partition_info() fails for this case, the
fatload code falls back to the assumption that there is no partition
table and does the right thing then.

Please consider applying the following patch.

Daniel




More information about the U-Boot mailing list