[U-Boot] [PATCH] mem_mtest: bail out after finding 1st memory error.

[Wolfgang Denk]

Dear Paul Gortmaker,

In message <1254338488-15332-1-git-send-email-paul.gortmaker at windriver.com> you wrote:
> The basic memtest function tries to watch for ^C after each
> pattern pass as an escape mechanism, but if things are horribly
> wrong, we'll be stuck in an inner loop flooding the console with
> error messages and never check for ^C.  To make matters worse,
> if the user waits for all the error messages to complete, we
> then incorrectly report the test passed without errors.
> 
> By inspecting the code, it is clear that the test was originally
> written with returning after the 1st error in mind (which is what
> the optional more extensive test does).  Making it do this also
> solves the endless console flood problem if a person tests really
> bad RAM.

Please don't change the behaviour, rather fix the problems with it.

If you like, please feel free to add code to bail out after a number
of errors, but that should be optional (for example using an
additional argument on the command line).


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I used to be indecisive, now I'm not sure.