[U-Boot] kirkwood (openrd): saveenv will not work with environment in NAND

[Wolfgang Denk]

Dear Simon Kagstrom,

In message <20090930095710.3480bb58 at marrow.netinsight.se> you wrote:
>
> Wolfgang/Stefan/Tom/Prafulla: Would a patch like the one below be
> acceptable until we find out a proper fix? I realise that this also
> affects other arm926ejs-boards, but is there some way to isolate this
> to kirkwood?

No and yes :-)

> --- a/cpu/arm926ejs/config.mk
> +++ b/cpu/arm926ejs/config.mk
> @@ -20,10 +20,11 @@
>  # Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>  # MA 02111-1307 USA
>  #
> +USE_PRIVATE_LIBGCC = yes

I will reject this part. USE_PRIVATE_LIBGCC should only be needed on
broken tool chains (at least that's the theory), and the default case
is always to assume we live in a perfect world where all tools are
working as they are expected to do.

>  PLATFORM_RELFLAGS += -fno-common -ffixed-r8 -msoft-float
>  
> -PLATFORM_CPPFLAGS += -march=armv5te
> +PLATFORM_CPPFLAGS += -march=armv5te -mabi=apcs-gnu

I could live with this part, if it was thoroughly tested and does not
cause problems with the most frequently used tool chains (which I'm
afraid it would - I think I remember that I saw errors or unexpected
behaviour when using multiple, different "-mabi" settings).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Inside every old person is a young person wondering what happened.
                              - Terry Pratchett, _Moving Pictures_