[U-Boot] [PATCH 3/6] Adding uC5272 dimm module support

Wolfgang Denk wd at denx.de
Sat Apr 10 23:25:00 CEST 2010


Dear "David Wu",

In message <op.vawht1pjqigx4y at cyprus.local> you wrote:
> Signed-off-by: David Wu <davidwu at arcturusnetworks.com>
> ---
>     Makefile                         |   46 +++++
>     board/Arcturus/uC5272/Makefile   |   44 +++++
>     board/Arcturus/uC5272/config.mk  |    1 +
>     board/Arcturus/uC5272/u-boot.lds |  142 +++++++++++++++
>     board/Arcturus/uC5272/uC5272.c   |   57 ++++++
>     include/configs/uC5272.h         |  354
> ++++++++++++++++++++++++++++++++++++++
>     6 files changed, 644 insertions(+), 0 deletions(-)
>     create mode 100644 board/Arcturus/uC5272/Makefile
>     create mode 100644 board/Arcturus/uC5272/config.mk
>     create mode 100644 board/Arcturus/uC5272/u-boot.lds
>     create mode 100644 board/Arcturus/uC5272/uC5272.c
>     create mode 100644 include/configs/uC5272.h


I hereby NAK the whole patch series, which seems to have none of the
issues fixed that I raised in my earlier review comments.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
:       I've tried (in vi) "g/[a-z]\n[a-z]/s//_/"...but that doesn't
: cut it.  Any ideas?  (I take it that it may be a two-pass sort of solution).
In the first pass, install perl. :-) Larry Wall <6849 at jpl-devvax.JPL.NASA.GOV>


More information about the U-Boot mailing list