[U-Boot] [PATCH 3/3] mpc83xx: turn on icache in core initialization to improve u-boot boot time

[Scott Wood]

Kim Phillips wrote:
> On Fri, 16 Apr 2010 20:06:02 +0300
> Michael Zaidman <michael.zaidman at gmail.com> wrote:
> 
>> On Fri, Apr 16, 2010 at 1:36 AM, Kim Phillips
>> <kim.phillips at freescale.com> wrote:
>>> before, MPC8349ITX boots u-boot in 4.3sec:
>> [snip]
>>> after, MPC8349ITX boots u-boot in 3.0sec:
>> Thanks for the good news! Memory POST test on my board with icach
>> disabled was lasting for hours until I enabled icach locally before
>> and disabled it after time consuming tests.
>>
>> BTW is there any reason that you enable icach in board specific rather
>> than in common code?
> 
> not really, was just following the existing HID0-setting paradigm -
> I presume the paradigm came about to allow different cpu/board
> combinations to enable/disable different HID bits.  Does that not sound
> valid to you?

Shouldn't you be using icache_enable(), or at least using HID0_INIT to 
do invalidation and lock clearing?

-Scott