[U-Boot] [PATCH RFC] OMAP: mmc: add support for second and third mmc channels

Steve Sakoman sakoman at gmail.com
Thu Apr 29 22:20:43 CEST 2010


On Thu, Apr 29, 2010 at 12:55 PM, Steve Sakoman <sakoman at gmail.com> wrote:
> On Thu, Apr 29, 2010 at 11:15 AM, Scott Wood <scottwood at freescale.com> wrote:
>> The mandatory use of structs even with large reserved areas seems to invite
>> and obscure such issues (and the comments don't help much, since nothing
>> ensures they're accurate).
>
> Good catch!
>
> Agreed  -- I really hate sparse structs like this since they just
> invite this type of error when you fill in missing registers.
>
> I'll fix and resubmit the patch for further comment.

BTW, the reason I didn't catch this in testing is that the error would
only show up for mmc channel 2, which is not available on Overo (it is
used for the SDIO wifi interface).  My testing was done on mmc1 and
mmc2.

Steve


More information about the U-Boot mailing list