[U-Boot] [PATCH] board/purple/flash.c: removed unneded variable

Frans Meulenbroeks fransmeulenbroeks at gmail.com
Sun Aug 1 13:31:50 CEST 2010


2010/8/1 Sergei Shtylyov <sshtylyov at mvista.com>

> Hello.
>
>
> Frans Meulenbroeks wrote:
>
>  removed a variable that was not used
>>
>
>  Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks at gmail.com>
>>
>
> [...]
>
>
>  diff --git a/board/purple/flash.c b/board/purple/flash.c
>> index 37c7bec..5cee35e 100644
>> --- a/board/purple/flash.c
>> +++ b/board/purple/flash.c
>>
> [...]
>
>  @@ -490,7 +489,7 @@ int flash_erase (flash_info_t *info, int s_first, int
>> s_last)
>>        last  = get_timer(0);
>>        /* Start erase on unprotected sectors */
>> -       for (sect = s_first; sect<=s_last && rcode == 0; sect++) {
>> +       for (sect = s_first; sect<=s_last; sect++) {
>>
>
>   High time to insert space before and after <=...
>
>
> WBR, Sergei
>

Be my guest :-)
I happen to bump onto the variable issue and decided to fix it, but have no
binding with this board (I don't even know what kind of board it is, and I
have no desire or intention to clean this up)

BTW: if layout is deemed so important I suggest running the code through a
prettyprinter/layout program/code beautifier.

Have fun! Frans


More information about the U-Boot mailing list