[U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block

Kumar Gala galak at kernel.crashing.org
Mon Aug 2 17:51:10 CEST 2010


On Aug 2, 2010, at 10:43 AM, Timur Tabi wrote:

> Kumar, do you have any issues with this patch?  I submitted it in May,
> but you never picked it up.
> 
> On Mon, May 24, 2010 at 3:10 PM, Timur Tabi <timur at freescale.com> wrote:
>> The device tree (fdt) must always exist in within the bootmap (usually the
>> first 16MB of RAM).  If it doesn't, then boot_relocate_fdt() will allocate an
>> LMB region in the bootmap and copy the fdt into that region.  It will also
>> increase the size of the fdt.
>> 
>> If the fdt is already in the bootmap, then previously the memory was just
>> reserved.  There was no contingency if the reservation failed, however.
>> 
>> By always allocating an lmb region and copying/resizing the fdt into that
>> region, the code is simplified and the memory region is always allocated
>> properly.
>> 
>> Also change the types of some variables to avoid some typecasts.
>> 
>> Signed-off-by: Timur Tabi
> 
> -- 
> Timur Tabi
> Linux kernel developer at Freescale

As this isn't to 8xxx related code I'm NOT going to apply it.  Wolfgang should.

- k


More information about the U-Boot mailing list