[U-Boot] [PATCH V5 4/4] edminiv2: add mvsata_ide and cmd_ide support

[Prafulla Wadaskar]

> -----Original Message-----
> From: Prafulla Wadaskar 
> Sent: Tuesday, August 03, 2010 5:40 PM
> To: 'Albert ARIBAUD'
> Cc: u-boot at lists.denx.de; tanmay.upadhyay at einfochips.com; 
> Prabhanjan Sarnaik; Ashish Karkare
> Subject: RE: [PATCH V5 4/4] edminiv2: add mvsata_ide and 
> cmd_ide support
> 
...snip...
> > 
> > Actually two things were necessary to get ide reset to work 
> reliably:
> > 
> > 1) adding a delay between the writes to SControl. 
> > Experimentation showed 
> > this delay should be at least 41 us on my board. I have set 
> > it to 50 us 
> > to play safe on possible HW characteristics dispersions.
> > 
> > 2) moving the call(s) to mvsata_ide_initialize_port() from 
> > board_init() 
> > function to function ide_preinit(), which is called just 
> > before an IDE 
> > reset if CONFIG_IDE_INIT is set -- accordingly, I added 
> > ide_preinit() to 
> > openrd_base.c and defined CONFIG_IDE_INIT in kirkwood.h.
> > 
> > Prafulla, can you try the patch attached above yours?
> 
> Sure, I will try this and let you know

Hi Albert

It worked for me.
You may post V7, then I will post my patches for Kirkwood sata support

I have two more suggestion,
1. put ide_preinit function in mvsata driver, define CONFIG_IDE_PREINIT in board config file  

2. pls remove the blank lines between each command in function mvsata_ide_initialize_port, it looks ugly.

3. Instead of adding fixed 41/50 usec delay between the writes to Scontrol
It would be good if you can check/poll some status bit associated with IDE controller, this will make mvsata driver rock solid on any platform.

Regards..
Prafulla . .

> 
> Regards..
> Prafulla . .
> 
> > 
> > If this works, then I'll backport the above fixes to 
> orion5x/edminiv2 
> > and post a V7 patch.
> > 
> > Amicalement,
> > -- 
> > Albert.
> >