[U-Boot] [PATCH V7 3/4] cmd_ide: add support for orion5x

[Albert ARIBAUD]

Le 05/08/2010 20:43, Prafulla Wadaskar a écrit :
>
>
>> -----Original Message-----
>> From: u-boot-bounces at lists.denx.de
>> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
>> Sent: Thursday, August 05, 2010 6:06 PM
>> To: u-boot at lists.denx.de
>> Subject: [U-Boot] [PATCH V7 3/4] cmd_ide: add support for orion5x
>>
>> Add MVSATAHC definitions to orion5x.
>> Add support for orion5x in cmd_ide.
>>
>> Signed-off-by: Albert Aribaud<albert.aribaud at free.fr>
>> ---
>>   arch/arm/include/asm/arch-orion5x/orion5x.h |    3 +++
>>   common/cmd_ide.c                            |    5 +++++
>>   2 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-orion5x/orion5x.h
>> b/arch/arm/include/asm/arch-orion5x/orion5x.h
>> index d257b66..e3d3f76 100644
>> --- a/arch/arm/include/asm/arch-orion5x/orion5x.h
>> +++ b/arch/arm/include/asm/arch-orion5x/orion5x.h
>> @@ -55,6 +55,9 @@
>>   #define ORION5X_USB20_PORT0_BASE		
>> (ORION5X_REGISTER(0x50000))
>>   #define ORION5X_USB20_PORT1_BASE		
>> (ORION5X_REGISTER(0xA0000))
>>   #define ORION5X_EGIGA_BASE			
>> (ORION5X_REGISTER(0x72000))
>> +#define ORION5X_SATA_BASE			
>> (ORION5X_REGISTER(0x80000))
>> +#define ORION5X_SATA_PORT0_OFFSET		0x2000
>> +#define ORION5X_SATA_PORT1_OFFSET		0x4000
>
> These two macros are mvsata specific and going to duplicate in Kirkwood port too.
> Why not to move them to mvsata.c?

Because the abstracted driver does not know at what address it is 
instantiated in each SoC; this is known at SoC level.

>>   /* Orion5x GbE controller has a single port */
>>   #define MAX_MVGBE_DEVS	1
>> diff --git a/common/cmd_ide.c b/common/cmd_ide.c
>> index d423e53..b23db3f 100644
>> --- a/common/cmd_ide.c
>> +++ b/common/cmd_ide.c
>> @@ -25,6 +25,7 @@
>>   /*
>>    * IDE support
>>    */
>> +
>>   #include<common.h>
>>   #include<config.h>
>>   #include<watchdog.h>
>> @@ -45,6 +46,10 @@
>>   #include<mpc5xxx.h>
>>   #endif
>>
>> +#ifdef CONFIG_ORION5X
>> +#include<asm/arch/orion5x.h>
>> +#endif
>
> What makes it important to include this file here?

This file uses the CONFIG_SYS_ATA_xxx macros, which expand to ORION5X 
(and KW for kirkwood) macros.

The macros and include are actually based on the same principle as for 
the mvgbe driver base and port offset.

> Regards..
> Prafulla . .

Amicalement,
-- 
Albert.