[U-Boot] [PATCH v3 0/8] NDS32: Add NDS32 architecture support to u-boot.

[Wolfgang Denk]

Dear Macpaul Lin,

In message <1281083452-17616-1-git-send-email-macpaul at andestech.com> you wrote:
> NDS32 is a new 32-bit RISC architecture invented by andestech.com.
> 
> It has a 16-bit/32-bit mixed-length instruction set to achieve optimal
> system performance, code density, and power efficiency.
> 
> NDS32 also provide N9, N10, N12 different CPU core families for soft-core
> and hard-core SoC design.
> 
> Macpaul Lin (8):
>   nds32: add support of general functions in arch lib
>   nds32: add cpu support for nds32 arch
>   nds32: add header files support for nds32
>   nds32: add header files support for soc ag101
>   nds32: add standalone related support for nds32
>   nds32: add common support for nds32
>   nds32: add board adp-ag101 support
>   ftrtc010.c : enhance code according to original datasheet

A few more comments...

Please try and reorder your patches in a way that is "logical"; for
example, your patch 1/8 adds these files:

	 create mode 100644 arch/nds32/lib/Makefile
	 create mode 100644 arch/nds32/lib/board.c
	 create mode 100644 arch/nds32/lib/bootm.c
	 create mode 100644 arch/nds32/lib/interrupts.c

which are then hanging completely unsupported in free air. There are
no users for this code anywhere...  Keepo in mind that all commits
shall be bisectable.


Second, please clean up your code and add or include only things that
are really used or needed on your architecture. I doubt that NDS32
uses the AT91 DataFlash drivers? I doubt even more that there will be
a NDS32 based system with a VFD display?  Then why do you copy all
that crap^H^H^H^Hstuff into your architecture support?  Ther eis
literally tons of stuff in your files that are guaranteed to be
completely irrelevant.


Third, it seems that you chose to follow the ARM architecture as
example.  That was a bad choice, actually, as ARM has a lot of design
deficiencies - which you all copied. As a minimum, make sure to look
at Heikos recent reorganization for the ARM acrhitecture and base your
code on _that_ approach. See:

| Git:
| git://git.denx.de/u-boot-testing.git arm-reloc-and-cache-support
| 
| URL:
| http://git.denx.de/?p=u-boot/u-boot-testing.git;a=shortlog;h=refs/heads/arm-reloc-and-cache-support

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Do not simplify the design of a program if a way can be found to make
it complex and wonderful.