[U-Boot] [PATCH] ext2fs: Fix optimization bug for doubly-indirect block pointers
Wolfgang Denk
wd at denx.de
Sat Aug 7 23:02:27 CEST 2010
Dear Aaron Pace,
In message <4C4DEF0C.3020102 at alcatel-lucent.com> you wrote:
> Apologies for the oversight, here's the non line-wrapped version.
It is still white space corrupted - where the original code has TABs,
your file has all SPACEs only.
Please never try to cvopy & paste patches, this does not work. Use
git-send-email instead.
Also note that such comments as the line above do not belong into the
commit messgae - they belong into the comment section, i. e. below the
"---" line.
> Fix optimization bug for doubly-indirect block pointers
>
> Doubly-indirect block numbers are compared against the first-level
> indirect block when checking for a cached copy. This is causing the
> doubly-indirect block to be re-read each time it is accessed.
> Repairing this reduces load time for a 70M file from 72 seconds
> to 38 seconds.
>
> Signed-off-by: Aaron Pace <Aaron.Pace at alcatel-lucent.com>
> ---
^^^^^^^^^
Here is where comments may be added.
> fs/ext2/ext2fs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied manually.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unix is like a toll road on which you have to stop every 50 feet to
pay another nickel. But hey! You only feel 5 cents poorer each time.
- Larry Wall in <1992Aug13.192357.15731 at netlabs.com>
More information about the U-Boot
mailing list