[U-Boot] [PATCH v3 2/4] mtdparts: show net size in mtdparts list

Wolfgang Denk wd at denx.de
Sun Aug 8 15:16:15 CEST 2010


Dear Harald Welte,

In message <20100808040649.GI12062 at prithivi.gnumonks.org> you wrote:
> 
> On Sat, Aug 07, 2010 at 10:08:50PM +0200, Wolfgang Denk wrote:
> > >  * update copyright of cmd_mtdparts.c
> > 
> > That was a bad idea.  We do not add change logs to files, because we
> > have the full history of changes in git.
> 
> just to clearly understand your point: Your objection is against the 
> 
> > > + *   Added net partition size output to mtdparts list command
> 
> in the file itself, as it should be a changelog.  Your objection is
> (I hope) not against the author claiming copyright in the source code
> file itself, right?

Correct.

> Copyright claims are something that you can hardly deny any author
> in the work itself - particularly since the majority of distributions
> are made as tarballs that do not contain the full git history.

Agreed - at least for any significant contribution to the code. I
don't think you mean that eauch author of a 10 line patch to a 1000
line file  shouldbe added to the list of copyright holders?

In this respect, the patch we're discussing here is a bit on the
border: it's adding some 1...2% to the code size of this file, and the
code is not exactly challanging.  I would not have asked to have my
own (C) added in a similar situation.

But to make things clear: My objection was against adding change log
information.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is a good thing for an uneducated man to read books of quotations.
                        - Sir Winston Churchill _My Early Life_ ch. 9


More information about the U-Boot mailing list