[U-Boot] [PATCH] ext2fs: Fix optimization bug for doubly-indirect block pointers
Wolfgang Denk
wd at denx.de
Mon Aug 9 01:01:17 CEST 2010
Dear Aaron Pace,
In message <4C4DE8DC.4020500 at alcatel-lucent.com> you wrote:
> Fix optimization bug for doubly-indirect block pointers
>
> Doubly-indirect block numbers are compared against the first-level
> indirect block when checking for a cached copy. This is causing the
> doubly-indirect block to be re-read each time it is accessed.
> Repairing this reduces load time for a 70M file from 72 seconds
> to 38 seconds.
>
> Signed-off-by: Aaron Pace <Aaron.Pace at alcatel-lucent.com>
> ---
> fs/ext2/ext2fs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext2/ext2fs.c b/fs/ext2/ext2fs.c
> index 4b391d6..a88cf87 100644
> --- a/fs/ext2/ext2fs.c
> +++ b/fs/ext2/ext2fs.c
> @@ -364,7 +364,7 @@ static int ext2fs_read_block (ext2fs_node_t node,
> int fileblock) {
> indir2_size = blksz;
> }
> if ((__le32_to_cpu (indir1_block[rblock / perblock]) <<
> - log2_blksz) != indir1_blkno) {
> + log2_blksz) != indir2_blkno) {
> status = ext2fs_devread
> (__le32_to_cpu(indir1_block[rblock / perblock]) << log2_blksz,
This patch is line-wrapped, please make sure to fix yourmailer.
This has already been applied, so no need to resubmit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
KLB is an acronym for `Known Lazy Bastard', aka non-FAQ reader, aka
person who would rather make someone take their time to explain
something basic than look it up in a FAQ.
-- Tom Christiansen in <6aq547$mnr$2 at csnews.cs.colorado.edu>
More information about the U-Boot
mailing list