[U-Boot] [PATCH] net: Fix faulty definition of uec_initialize()

Joakim Tjernlund joakim.tjernlund at transmode.se
Tue Aug 10 07:52:10 CEST 2010


Ben Warren <biggerbadderben at gmail.com> wrote on 2010/08/09 22:54:10:
>
>   On 8/9/2010 1:18 PM, Mike Frysinger wrote:
> > On Mon, Aug 9, 2010 at 3:15 PM, Joakim Tjernlund wrote:
> >> The correct definition is in drivers/qe/uec.h so just
> >> include that one instead.
> > ... except that bleeds a ton of crap from uec.h into the global
> > namespace for everyone.  better would be to move the prototype out of
> > uec.h and into netdev.h and make sure uec.h includes netdev.h.

hmm, then the public include file for UEC users become "../drivers/uec.h"
while every one else uses netdev.h, doesn't seem the right way go

BTW, UEC users needs the macro STD_UEC_INFO() too.

> > -mike
> > _______
> Agreed.  Please find a way to have UEC-related stuff only on boards that
> care about it.

OK, but I will let Freescale sort this out. I just wanted to fix
the compile breakage I noticed while upgrading my board to latest
u-boot(still in progress)



More information about the U-Boot mailing list