[U-Boot] [PATCH] bug fix and cleanup for s3c44b0 serial driver

[Reinhard Meyer]

Dear Minkyu Kang,

my five cents:

>>  #define REGL(addr)     (*(volatile unsigned int *)(REGBASE+addr))
>>  #define REGW(addr)     (*(volatile unsigned short *)(REGBASE+addr))
>>  #define REGB(addr)     (*(volatile unsigned char *)(REGBASE+addr))

isn't that way of accessing hardware VERY depreciated?

 >> +#define BRD(bps)       (DIV_ROUND(CONFIG_S3C44B0_CLOCK_SPEED * 1000000, \
 >> > +                               (bps)*16) - 1)
 >
 >no need brace and please add the space around the operator.
 >bps * 16) - 1)

its always wise to () a macro parameter and not make assumptions on the
parameters. What about BRD(9600+9600) ?

>>  /*****************************/
>>  /* CPU Wrapper Registers     */

I think that version of multi-line comment is not allowed...

Best Regards, Reinhard