[U-Boot] [PATCH] net: Fix faulty definition of uec_initialize()

[Joakim Tjernlund]

vapierfilter at gmail.com wrote on 2010/08/10 08:04:02:
>
> On Tue, Aug 10, 2010 at 1:52 AM, Joakim Tjernlund wrote:
> > Ben Warren wrote on 2010/08/09 22:54:10:
> >>  On 8/9/2010 1:18 PM, Mike Frysinger wrote:
> >> > On Mon, Aug 9, 2010 at 3:15 PM, Joakim Tjernlund wrote:
> >> >> The correct definition is in drivers/qe/uec.h so just
> >> >> include that one instead.
> >> > ... except that bleeds a ton of crap from uec.h into the global
> >> > namespace for everyone.  better would be to move the prototype out of
> >> > uec.h and into netdev.h and make sure uec.h includes netdev.h.
> >
> > hmm, then the public include file for UEC users become "../drivers/uec.h"
> > while every one else uses netdev.h, doesn't seem the right way go
>
> which isnt uncommon today.  simply grep the tree for
> "include.*drivers/net/".  while i agree it isnt exactly a great idea,
> there is no clean standard today in u-boot for drivers to expose their
> internals to random consumers.  some drivers dump their header files
> into include/, so personally, i prefer the include ../driver/net/..
> style over that.

I see, but that defeats the purpose of netdev.h I think. Oh well,
just gonna have to live with that then.

 Jocke