[U-Boot] [PATCH 8/9] PXA: Balloon3 board support

[Wolfgang Denk]

Dear Marek Vasut,

In message <1281415810-31363-8-git-send-email-marek.vasut at gmail.com> you wrote:
> The following hardware is currently supported:
> - UART
> - USB Host
> - FPGA
> 
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> ---
>  MAKEALL                        |    1 +
>  board/balloon3/Makefile        |   49 +++++++
>  board/balloon3/balloon3.c      |  227 +++++++++++++++++++++++++++++++++
>  board/balloon3/config.mk       |    1 +
>  board/balloon3/lowlevel_init.S |   36 ++++++
>  board/balloon3/u-boot.lds      |   55 ++++++++
>  boards.cfg                     |    1 +
>  include/configs/balloon3.h     |  270 ++++++++++++++++++++++++++++++++++++++++
>  8 files changed, 640 insertions(+), 0 deletions(-)
>  create mode 100644 board/balloon3/Makefile
>  create mode 100644 board/balloon3/balloon3.c
>  create mode 100644 board/balloon3/config.mk
>  create mode 100644 board/balloon3/lowlevel_init.S
>  create mode 100644 board/balloon3/u-boot.lds
>  create mode 100644 include/configs/balloon3.h

MAINTAINERS entry missing.

...
> +int board_init (void)
> +{
> +	/* memory and cpu-speed are setup before relocation */
> +	/* so we do _nothing_ here */

Nothing?  This comment is wrong.

> +	/* arch number of vpac270 */
> +	gd->bd->bi_arch_number = MACH_TYPE_BALLOON3;
> +
> +	/* adress of boot parameters */
> +	gd->bd->bi_boot_params = 0xa0000100;
> +
> +	/* Init the FPGA */
> +	balloon3_init_fpga();

This is definitely more than nothing.


> +	UHCHR = (UHCHR | UHCHR_PCPL | UHCHR_PSPL) &
> +		~(UHCHR_SSEP0 | UHCHR_SSEP1 | UHCHR_SSEP2 | UHCHR_SSE);
> +
> +	UHCHR |= UHCHR_FSBIR;

Please use I/O accessors to access device registers.  Please fix
globally.

> +	while (UHCHR & UHCHR_FSBIR);

The semicolon goes to the next line.


> +#ifdef	CONFIG_CMD_KGDB
> +#define	CONFIG_KGDB_BAUDRATE		230400		/* speed to run kgdb serial port */

Line too long. Please fix globally.



I stop reviewing here.  Please check the other patches for similar
issues, and fix these as well.  Please also re-read the review
comments for the first patch series.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am not now, nor have I ever been, a member of the demigodic party.
                                                   -- Dennis Ritchie