[U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

Mike Frysinger vapier at gentoo.org
Thu Aug 12 21:43:34 CEST 2010


On Thu, Aug 12, 2010 at 2:04 PM, Remy Bohmer wrote:
> 2010/8/10 Mike Frysinger:
>> On Tue, Aug 10, 2010 at 6:26 AM, Sergei Shtylyov wrote:
>>> Mike Frysinger wrote:
>>>> --- a/drivers/usb/musb/musb_hcd.c
>>>> +++ b/drivers/usb/musb/musb_hcd.c
>>>>        } else {
>>>> -               if (!toggle)
>>>> -                       writew(MUSB_RXCSR_CLRDATATOG, &musbr->rxcsr);
>>>> -               else {
>>>> +               if (!toggle) {
>>>> +                       csr = readw(&musbr->txcsr);
>>>> +                       if (csr & MUSB_TXCSR_MODE)
>>>> +                               csr = MUSB_RXCSR_CLRDATATOG;
>>>
>>>   Clearing RXCSR when FIFO is in TX mode?
>>
>> unless i missed something, that is what Linux is doing.
>
> Can Linux be wrong too?

anything is possible, but i dont believe people have complained about
this working incorrectly on their platforms, else it'd be fixed by now
i imagine
-mike


More information about the U-Boot mailing list