[U-Boot] [PATCH] cfi_flash: flinfo: allow user interrupt in flash print info fn
Wolfgang Denk
wd at denx.de
Thu Aug 12 23:02:32 CEST 2010
Dear Kim Phillips,
In message <20100726183539.1732824f.kim.phillips at freescale.com> you wrote:
> flashes getting larger, users more impatient.
>
> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
> ---
> drivers/mtd/cfi_flash.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
> index 3267c5d..38d0ca5 100644
> --- a/drivers/mtd/cfi_flash.c
> +++ b/drivers/mtd/cfi_flash.c
> @@ -1159,6 +1159,8 @@ void flash_print_info (flash_info_t * info)
>
> puts ("\n Sector Start Addresses:");
> for (i = 0; i < info->sector_count; ++i) {
> + if (ctrlc())
> + return;
> if ((i % 5) == 0)
> printf ("\n");
> #ifdef CONFIG_SYS_FLASH_EMPTY_INFO
NAK. This code (and the existing "if ((i % 5) == 0) printf ("\n");" as
well) is incorrectly placed, i. e. before variable declarations.
Please fix.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
HEALTH WARNING: Care Should Be Taken When Lifting This Product, Since
Its Mass, and Thus Its Weight, Is Dependent on Its Velocity Relative
to the User.
More information about the U-Boot
mailing list