[U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

Reinhard Meyer u-boot at emk-elektronik.de
Fri Aug 13 00:58:15 CEST 2010


Dear Remy Bohmer,

just some more observations:

1. The USB device port hardware in AT91SAM9* is called "UDP".
So files that are AT91 specific should have "udp" in their names,
not "udc". I know LinuX did do it wrong already...

2. At one part the header file for at9sam9261 is unconditionally
included, and none for the other at91 variants. Have you verified
that this is OK for all at91 variants? Besides that if so, the
common parts used should probably be moved to an extra at91_*.h
file.

3. I did not follow the whole USB patches, my concern is
what touches AT91, but please explain to me what for we need
a board under u-boot to be a USB device. Since u-boot per se
is not multitasking how is the traffic handled while
at the command prompt?

Which leads to:
4. Which hardware did you test that on, and what device
functionality?

Best Regards,
Reinhard


More information about the U-Boot mailing list