[U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout
Stefano Babic
sbabic at denx.de
Fri Aug 13 10:55:16 CEST 2010
Vitaly Kuzmichev wrote:
> Take debug printout macros back from linux-2.6.27 and make them more
> useful and more compatible.
>
> Signed-off-by: Vitaly Kuzmichev <vkuzmichev at mvista.com>
> ---
> drivers/usb/gadget/ether.c | 65 +++++++++++++++++++++++---------------------
> 1 files changed, 34 insertions(+), 31 deletions(-)
>
Hi Vitaly,
a general comment. In u-boot is DEBUG generally defined to activate the
output, as you see in a lot of drivers. It should not be changed as
meanining in a single driver.
However, it seems more consistent to apply the comment sent by Reinhard:
http://lists.denx.de/pipermail/u-boot/2010-August/075346.html
debug() is already provided in u-boot, it makes sense not to add another
slightly modification of a debug output.
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
More information about the U-Boot
mailing list