[U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

[Wolfgang Denk]

Dear Remy Bohmer,

In message <AANLkTinv_4m6CfVzGd+ofF1cinzUWEJHiutdd9rPfgas at mail.gmail.com> you wrote:
> 
> > There are so many lines changed already in the code that claoming
> > "This file is copied from Linux." does not make much sense any more.
> 
> Well, it is derived from 2.6.27, not latest git.
> True, there are differences, but mostly it is a strip down of the
> original code( /proc support is removed for example)
> And I also noticed that the file can be synced to Linux more than it
> currently is...

Well, if your argument is true that the current code can easily be
kept in sync with Linux, then why is it already 8 kernel releases old?

How about syncing it with Linux, before adding it to U-Boot?

> >> Yep, if that happens things are really broken...
> >
> > So broken that you cannot get back to the command line interpreter?
> > Really?
> 
> If malloc is broken, I consider that reason enough for hang/reboot...

That's not a good idea.  Please fix.

> > And that justifies it all.
> 
> No, but please look at the overall goal here. It was the goal to use
> the Linux code as much as-is, and to allow easy merging new driver
> code in the future. Everything can be made better, but in that case I
> would prefer to first make the origin better, and port that back to
> U-boot.

Well, the origin has improved by 8 kernel releases since.

Would it make sense to update?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A witty saying proves nothing, but saying  something  pointless  gets
people's attention.