[U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

Sergei Shtylyov sshtylyov at mvista.com
Fri Aug 13 12:45:29 CEST 2010


Hello.

Vitaly Kuzmichev wrote:

>>> -            printf ("enable %s --> %d\n",
>>> +            DEBUG(dev, "enable %s --> %d\n",

>>   Well, I think the coding style shouldbe consistent -- you either leave
>> the space before ( or remove it. And as U-Boot seems to follow the Linux
>> coding style now, it seems better to remove the space.

> Well, I would say: "either leave the space before ( or remove it from
> EVERYWHERE".
> I think that the last thing should be done as a separate patch.
> So I would like to keep the coding style that is in this file.

    Which you've failed to do so far. ;-)

> Best regards,
> Vitaly.

WBR, Sergei


More information about the U-Boot mailing list