[U-Boot] [PATCH] UEC PHY: Speed up initial PHY neg.

Joakim Tjernlund joakim.tjernlund at transmode.se
Fri Aug 13 15:18:06 CEST 2010


Detlev Zundel <dzu at denx.de> wrote on 2010/08/13 10:20:46:
>
> Hi Jocke,
>
> >> > Instead of always performing an autoneg, check if the PHY
> >> > already has a link and if it matches one of the requested
> >> > modes. Initially only 100MbFD is optimized this way.
> >>
> >> Isn't it about time that we think about _not_ stopping the ethernet
> >> device after every transaction?
> >
> > Hi Detlev
> >
> > UEC does this already, my patch was to address the initial delay
> > you get for the first transaction. Now my PHY based boards gets the link
> > up just as quick as Fixed PHY for the first transaction.
>
> Forgive me to not look into this any deeper, but do I understand you
> correctly that you do this by essentially no-oping the eth_halt()
> function?  Isn't this then effectively violating what net.c expects the
> device to do?

uec_halt stops the controller as it should. Uec forces an auto_neg
cycle on the PHY the first it is called, after that it just uses
the result from the first auto neg.
My patch simply skip the auto neg. pass iff the PHY already has
a link and duplex&speed already matches what uec wants.

    Jocke



More information about the U-Boot mailing list