[U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

Wolfgang Denk wd at denx.de
Fri Aug 13 16:06:43 CEST 2010


Dear Vitaly Kuzmichev,

In message <1281704276-29115-1-git-send-email-vkuzmichev at mvista.com> you wrote:
> Replace Linux-like debug printout macros by native ones.
> 
> Signed-off-by: Vitaly Kuzmichev <vkuzmichev at mvista.com>
> ---
>  drivers/usb/gadget/ether.c |   99 ++++++++++++++++++++-----------------------
>  1 files changed, 46 insertions(+), 53 deletions(-)
> 
> diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
> index a07738f..c287ec2 100644
> --- a/drivers/usb/gadget/ether.c
> +++ b/drivers/usb/gadget/ether.c
> @@ -20,6 +20,9 @@
>   * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
>   */
>  
> +#define DEBUG
> +#undef DEBUG
> +

NAK. Please remove this dead code.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every program has at least one bug and can be shortened by  at  least
one  instruction  --  from  which,  by induction, one can deduce that
every program can be reduced to one instruction which doesn't work.


More information about the U-Boot mailing list