[U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

Wolfgang Denk wd at denx.de
Fri Aug 13 16:08:06 CEST 2010


Dear Vitaly Kuzmichev,

In message <4C6544B9.3000503 at mvista.com> you wrote:
> 
> >> +#define DEBUG
> >> +#undef DEBUG
> >> +
> > 
> > Eh?
> 
> Such thing is used to let someone know that this driver supports debug
> output through native U-Boot macros. So one need to comment #undef to
> compile ether.c with debug messages.
> There are at least 67 files in U-Boot that use such construction.

Patches to clean up these are welcome.

I will NAK this whenever I see it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
PLEASE NOTE: Some Quantum Physics Theories Suggest That When the Con-
sumer Is Not Directly Observing This Product, It May Cease  to  Exist
or Will Exist Only in a Vague and Undetermined State.


More information about the U-Boot mailing list