[U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros
Wolfgang Denk
wd at denx.de
Fri Aug 13 16:09:38 CEST 2010
Dear Vitaly Kuzmichev,
In message <4C654B30.9060106 at mvista.com> you wrote:
> Hi Stefano,
>
> Stefano Babic wrote:
> > If you want to remember how to set the debug output, it should be enough
> > to add a comments with "to enable the debugging, define DEBUG before
> > common.h" or something like that. I vote to remove only the two lines...
>
> Would not it be better to make one of the following?
> 1)
> #if 0
> #define DEBUG
> #endif
>
> 2)
> #ifdef CONFIG_USB_ETH_DEBUG
> #define DEBUG
> #endif
NAK.
It is so trivial o #define DEBUG (either in the file or on the command
line) that thhere is zero need for any "clever" wrappers around this.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Behind every great man, there is a woman -- urging him on.
-- Harry Mudd, "I, Mudd", stardate 4513.3
More information about the U-Boot
mailing list