[U-Boot] [PATCH v4] at91: Don't initialize watchdog if CONFIG_SKIP_WATCHDOG_INIT is defined

[Mike Frysinger]

On Mon, Aug 9, 2010 at 7:42 AM, Alexander Stein wrote:
> Am Montag, 9. August 2010, 09:13:45 schrieb Mike Frysinger:
>> > On AT91 the watchdog mode register can only be written once after reset.
>> > If this register is written by u-boot e.g. a Linux driver can't
>> > reconfigure the watchdog later. If the watchdog is left untouched this
>> > is possible. Without touching the mode register the watchdog has a
>> > default setup and u-boot is still able to trigger the watchdog.
>> >
>> > [...]
>> >
>> > +- CONFIG_SKIP_WATCHDOG_INIT
>> > +
>> > +               [arm AT91 only] If this variable is defined, then the
>> > +               watchdog will not be programmed upon u-boot start.
>> > +               On AT91 the watchdog mode register can only be written
>> > +               once after reset. If this register is written by u-boot
>> > +               e.g. a Linux driver can't reconfigure the watchdog later.
>> > If +               the watchdog is left untouched this is possible. +
>> >             Without touching the mode register the watchdog has a
>> > default +               setup and u-boot is still able to trigger the
>> > watchdog.
>>
>> isnt the at91 logic inverted ?  shouldnt the watchdog programming only
>> be done when someone has opted in to it via some watchdog define ?
>
> This was my first version, but Wolfgang NAK'ed it as he see this as the wrong
> approach. See http://article.gmane.org/gmane.comp.boot-loaders.u-boot/81589

i think you interpreted his statement incorrectly ?  he said it should
raise an error, not that supporting CONFIG_HW_WATCHDOG is wrong.
-mike