[U-Boot] [PATCH] net: Change the NFS_TIMEOUT to 20s for using nfs load image.

Li Yang leoli at freescale.com
Mon Aug 16 12:25:45 CEST 2010


On Mon, Aug 16, 2010 at 6:09 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Li Yang,
>
> In message <1281947653-5530-1-git-send-email-leoli at freescale.com> you wrote:
>> From: Jin Qing <b24347 at freescale.com>
>>
>> The NFS_TIMEOUT is 2s before.  It is too short for some nfs server to respond.
>>
>> Signed-off-by: Jin Qing <b24347 at freescale.com>
>> ---
>> We are not sure what is the expected timeout period.  Using 20s to make sure
>> the mount works.
>>
>>  net/nfs.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/nfs.c b/net/nfs.c
>> index 4017c3e..cabadfe 100644
>> --- a/net/nfs.c
>> +++ b/net/nfs.c
>> @@ -33,7 +33,7 @@
>>
>>  #define HASHES_PER_LINE 65   /* Number of "loading" hashes per line  */
>>  #define NFS_RETRY_COUNT 30
>> -#define NFS_TIMEOUT 2000UL
>> +#define NFS_TIMEOUT 20000UL
>
> You mean 30 retries (NFS_RETRY_COUNT) every two seconds were not
> sufficient in your case?
>
> That's a full minute...

It didn't retry 30 times before it fails completely in our test:

Load address: 0x400000
Loading: T T T T T *** ERROR: Cannot mount
T T *** ERROR: Cannot umount

Looks like the state machine is not working as expected?

- Leo


More information about the U-Boot mailing list