[U-Boot] [PATCH 6/7] powerpc/qe: supports loading QE firmware from nand flash

[Wolfgang Denk]

Dear Haiying Wang,

In message <1281947090.24612.23.camel at localhost.localdomain> you wrote:
> and because some platforms need to load QE firmware from NAND flash(no NOR
> flash), it makes qe_init to be called after nand_init.
> 
> Signed-off-by: Haiying Wang <Haiying.Wang at freescale.com>
> ---
>  arch/powerpc/cpu/mpc83xx/cpu_init.c |    8 --------
>  arch/powerpc/cpu/mpc85xx/cpu_init.c |    8 --------
>  arch/powerpc/lib/board.c            |   31 +++++++++++++++++++++++++++++++
>  3 files changed, 31 insertions(+), 16 deletions(-)

Please do not throw such stuff into common code. Use board /
architecture specific implementations instead (say, provide some
misc_init_r() or so).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A list is only as strong as its weakest link.            -- Don Knuth