[U-Boot] [PATCH 4/7] powerpc/p1021: Add P1021MDS board support
Wolfgang Denk
wd at denx.de
Tue Aug 17 11:22:04 CEST 2010
Dear Haiying Wang,
In message <1282025889.2814.80.camel at localhost.localdomain> you wrote:
>
> > Please avoid adding a new header file just for this single prototype.
> This was copied from mpc8568mds/mpc8569mds. If it is not allowed anymore, I can remove it.
Please do.
Ideally provide a cleanup patch for mpc8569mds as well.
> > Why do you need a separate one anyway?
> Because it is p1021mds board specific reset routine.
Yes, what is the problem> We have support for board specific code
here, don't we?
> > Why cannot you implement this
> > in reset_phy() ?
> reset_phy() is a one time reset and called after eth_initialize(). But
> the board designer told me to reset phy for each UEC port before
> initializing it, otherwise the phy can not work properly.
Inded this needs to be reworked. Please wait a few days, there might
be a patch coming.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"We shall reach greater and greater platitudes of achievement."
- Richard J. Daley
More information about the U-Boot
mailing list