[U-Boot] [PATCH] powerpc/83xx: Fix build issue with ve8313 board due to lbus changes

Kumar Gala galak at kernel.crashing.org
Thu Aug 19 20:22:40 CEST 2010


On Aug 19, 2010, at 11:49 AM, Scott Wood wrote:

> On Thu, 19 Aug 2010 01:50:40 -0500
> Kumar Gala <galak at kernel.crashing.org> wrote:
> 
>> diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
>> index acdb431..ca61daf 100644
>> --- a/drivers/mtd/nand/fsl_elbc_nand.c
>> +++ b/drivers/mtd/nand/fsl_elbc_nand.c
>> @@ -1,6 +1,6 @@
>> /* Freescale Enhanced Local Bus Controller FCM NAND driver
>>  *
>> - * Copyright (c) 2006-2008 Freescale Semiconductor
>> + * Copyright (c) 2006-2010 Freescale Semiconductor
>>  *
>>  * Authors: Nick Spence <nick.spence at freescale.com>,
>>  *          Scott Wood <scottwood at freescale.com>
>> @@ -227,8 +227,10 @@ static int fsl_elbc_run_command(struct mtd_info *mtd)
>> 	     in_be32(&lbc->fbar), in_be32(&lbc->fpar),
>> 	     in_be32(&lbc->fbcr), priv->bank);
>> 
>> +#ifdef CONFIG_FSL_ELBC
>> 	/* execute special operation */
>> 	out_be32(&lbc->lsor, priv->bank);
>> +#endif
> 
> NACK, if you don't have an ELBC you have no business compiling this
> file at all.  This changes a loud failure to a quiet failure if someone
> forgets to define this symbol.

Ah, didn't even think about that from the file name, duh!

Will drop the change.

- k


More information about the U-Boot mailing list